Re: [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications

[Kirill A. Shutemov]

On Thu, Jan 7, 2010 at 3:01 AM, Paul Menage <menage@xxxxxxxxxx> wrote:
> On Wed, Dec 30, 2009 at 7:57 AM, Kirill A. Shutemov
> <kirill@xxxxxxxxxxxxx> wrote:
>> +
>> + Â Â Â if (!IS_ERR(efile))
>> + Â Â Â Â Â Â Â fput(efile);
>
> While this is OK currently, it's a bit fragile. efile starts as NULL,
> and IS_ERR(NULL) is false. So if we jump to fail: before trying to do
> the eventfd_fget() then we'll try to fput(NULL), which will oops. This
> works because we don't currently jump to fail: until after
> eventfd_fget(), but someone could add an extra setup step between the
> kzalloc() and the eventfd_fget() which could fail.

So we need to use IS_ERR_OR_NULL here instread of IS_ERR, don't we?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/