Re: [PATCH,RESEND] scsi: use __uX types for headers exported touser space

From: James Bottomley
Date: Thu Jan 07 2010 - 09:40:40 EST


On Thu, 2010-01-07 at 15:20 +0100, Peter Korsgaard wrote:
> Commit 9e4f5e29 (FC Pass Thru support) exported a number of header files
> in include/scsi to user space, but didn't change the uX types to the
> userspace-compatible __uX types. Without that you'll get compile errors
> when including them - E.G.:
>
> /tmp/include/scsi/scsi.h:145: error: expected specifier-qualifier-list
> before âu8â
>
> Signed-off-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> ---
> No feedback since 27/11, resending.

OK, so to summarise the list discussion, the current status is that the
SCSI exports are irrelevant because glibc currently ignores the
include/scsi namespace provided by the kernel. So, we have three
options:

1. Bring our exports up to the point where they can replace glibc's
include/scsi/scsi.h and the rest. This requires a line by line
analysis of what's in glibc and an update to our include to
provide or remove as necessary. After this is done we can try
to persuade the glibc people to turn over the include/scsi
namespace to us.
2. Kill the kbuild exports and make everyone go via the glibc tree
(current state).
3. Move the kernel include/scsi to a more conventional namespace
(like inside include/linux) so glibc will pick it up.

So far we've had people supporting all three. I'm inclined to say that
I'd favour 1, but the first patch trying to do any of them would be the
best starting ground for a discussion.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/