Re: [PATCH] netpoll: allow execution of multiple rx_hooks perinterface

From: David Miller
Date: Mon Jan 11 2010 - 18:59:12 EST


From: Matt Mackall <mpm@xxxxxxxxxxx>
Date: Mon, 11 Jan 2010 17:21:48 -0600

> Looks pretty good. Dave?
>
> Acked-by: Matt Mackall <mpm@xxxxxxxxxxx>

I don't like the loop for RX ARP processing.

The packet contents aren't going to change, so doing basic
packet validation inside of the "for each RX client" loop
of arp_reply() doesn't make any sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/