Re: [PATCH] procfs: Fix refcnt leak on proc_self_follow_link()error path

From: Andrew Morton
Date: Wed Jan 13 2010 - 19:25:45 EST


On Wed, 13 Jan 2010 19:43:01 +0000
Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Jan 12, 2010 at 03:38:36AM +0900, OGAWA Hirofumi wrote:
> >
> > If ->follow_link handler return the error, it should decrement
> > nd->path refcnt.
> >
> > This patch fix it.
>
> It's OK for -stable, but for the next tree... not really. I'd rather
> kill vfs_follow_link() uses here and in gfs2; see #untested in vfs-2.6.git
> for details.

Confused. Is #untested planned for 2.6.33? If not, how do we fix this
bug in .33?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/