Re: [PATCH] tracing: Drop the tr check from the graph tracing path

From: Steven Rostedt
Date: Thu Jan 14 2010 - 10:08:51 EST


On Thu, 2010-01-14 at 08:23 +0100, Frederic Weisbecker wrote:
> Each time we save a function entry from the function graph tracer,
> we check if the trace array is set, which is wasteful because it is
> set anyway before we start the tracer. All we need is to ensure we
> have good read and write orderings. When we set the trace array, we
> just need to guarantee it to be visible before starting tracing.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> Cc: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> kernel/trace/trace_functions_graph.c | 19 ++++++++++---------
> 1 files changed, 10 insertions(+), 9 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/