Re: [PATCH 00/15] Staging: Convert the semaphore mess

From: John Kacur
Date: Fri Jan 15 2010 - 10:47:31 EST




On Fri, 15 Jan 2010, Greg KH wrote:

> On Fri, Jan 15, 2010 at 04:11:23PM +0100, John Kacur wrote:
> >
> >
> > On Thu, 14 Jan 2010, Greg KH wrote:
> >
> > > On Mon, Jan 11, 2010 at 09:51:39PM +0100, John Kacur wrote:
> > > > Thomas / Ingo / Greg
> > > >
> > > > I started with the patch in -rt 041e3130496f31d0cb4887fc6183117e662f5141
> > > > and tried to forward port it to 2.6.33-rc3
> > > >
> > > > The patch no-longer applied, because some of the changes were already accepted
> > > > upstream, some files had been moved or dropped and so on.
> > > >
> > > > So, I broke the original patch into one patch per file, and fixed merge errors.
> > > > Then I also went and changed similar problems in new code
> > > >
> > > > This code should be queued-up for the 2.6.34 merge window, and should also
> > > > be applied to the latests -rt branch.
> > >
> > > I can't do that, as it breaks when applying to Linus's latest tree,
> > > right?
> > >
> > > If this needs to go through some other tree, no objection from me at
> > > all, feel free to add:
> > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > >
> > > to them.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > Hi Greg.
> >
> > This shouldn't break - I tested against 2.6.33-rc3, and I just retested
> > against 2.6.33-rc4. The origin of the patch is in -rt but there is nothing
> > -rt about it which is why I would like to push it upstream.
> >
> > I don't have all that hardware, so my ability to test it is somewhat
> > limited - and since these are all staging drivers, I was hoping that you
> > would pick it up if Thomas doesn't have any objections.
>
> Try applying your first patch against 2.6.33-rc3 and then just building
> the code. It dies a horrible death :)
>

Ugh! You're right Greg. These patches are pending Thomas's "Introduce
anon_semaphore" going upstream first.

I'll wait for that before pushing these again.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/