Re: [PATCH] idr: fix idr corruption when id crosses a layerboundary

From: Eric Paris
Date: Fri Jan 15 2010 - 16:33:32 EST


On Fri, 2010-01-15 at 13:24 -0800, Andrew Morton wrote:
> On Fri, 15 Jan 2010 16:14:50 -0500
> Eric Paris <eparis@xxxxxxxxxx> wrote:
>
> > inotify has for months been been having problems keeping the fsnotify view of
> > its objects in sync with the idr view of its objects. I discovered this was
> > only ever the case with the 4096th object created.
>
> Neato. Do you think this will help with all the inotify problems
> people have been having?

I do believe it should shut up the inotify WARN() people have been
seeing and the memory leak....

> Do you think this fix should go into 2.6.32.x and earlier?

If someone who really understands the idr and can explain the original
test that was there thinks it right I think it should. It's been broken
and able to produce corruption for a long time.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/