[tip:perf/urgent] perf timechart: Use tid not pid for COMM change

From: tip-bot for Arjan van de Ven
Date: Sun Jan 17 2010 - 02:00:55 EST


Commit-ID: 8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Gitweb: http://git.kernel.org/tip/8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Author: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
AuthorDate: Sat, 16 Jan 2010 12:53:19 -0800
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Sun, 17 Jan 2010 07:16:36 +0100

perf timechart: Use tid not pid for COMM change

A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid
to track this, and should have used the tid instead...

Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
CC: <stable@xxxxxxxxxx>
LKML-Reference: <20100116125319.34ac3edd@xxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
tools/perf/builtin-timechart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index a589a43..3f8bbcf 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];

static int process_comm_event(event_t *event, struct perf_session *session __used)
{
- pid_set_comm(event->comm.pid, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/