Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

From: Al Viro
Date: Sun Jan 17 2010 - 13:25:51 EST


On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:

> Signed-off-by: Emese Revfy <re.emese@xxxxxxxxx>
> Acked-by: David Teigland <teigland@xxxxxxxxxx>
> Acked-by: Matt Domsch <Matt_Domsch@xxxxxxxx>
> Acked-by: Maciej Sosnowski <maciej.sosnowski@xxxxxxxxx>
> Acked-by: Hans J. Koch <hjk@xxxxxxxxxxxxx>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> Acked-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

NACKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Same reason.

> - ssize_t (*show)(struct kobject *, struct attribute *, char *);
> - ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> + ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> + ssize_t (* const store)(struct kobject *, struct attribute *, const char *);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/