Re: [RFC PATCH 0/4] clockevents: fix clockevent_devices list corruptionafter cpu hotplug
From: Thomas Gleixner
Date: Mon Jan 18 2010 - 08:52:05 EST
On Mon, 18 Jan 2010, Xiaotian Feng wrote:
> On 01/17/2010 05:28 PM, Ozan ÃaÄlayan wrote:
> > Thomas Gleixner wrote:
> > >
> > > I'm not happy about that churn. Why don't we simply scan the
> > > clockevent_devices list for leftovers of the dead CPU ?
> > >
> > > Untested patch below solves the same problem.
> > Hi, I have 3 bug reports about a clockevent failure while halting the system
> > (22.214.171.124 kernel).
> > It exactly pinpoints to the line 262 which got changed with this patch
> > merged to 126.96.36.199 (and also 188.8.131.52):
> > [4406.986777] kernel BUG at kernel/time/clockevents.c:262!
> > [4406.986777] invalid opcode: 0000 [#1] SMP
> > [4406.986777] last sysfs file: /sysfs/module/ip_tables/initstate
> I think this one is duplicated of
> Thomas is working on the fix. I've sent a workaround patch on
I just applied your patch, but kept the cpuweight check. This is the
least intrusive solution for now. The logic needs an overhaul, but
thats neither rc4 nor stable material.