Re: [PATCH 22/64] pata_via: fix address setup timings underlocking

[Alan Cox]

On Mon, 18 Jan 2010 18:17:03 +0100
Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> Subject: [PATCH] pata_via: fix address setup timings underlocking
> 
> Correct via_do_set_mode() documentation while at it.

>  		setup &= ~(3 << shift);
> -		setup |= clamp_val(t.setup, 1, 4) << shift;	/* 1,4 or 1,4 - 1  FIXME */
> +		setup |= (clamp_val(t.setup, 1, 4) - 1) << shift;
>  		pci_write_config_byte(pdev, 0x4C, setup);

Change looks correct to me and matches the VT8235 data sheet (p.97)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/