Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c

[Jean Delvare]

On Mon, 18 Jan 2010 11:59:30 -0800, Joe Perches wrote:
> On Mon, 2010-01-18 at 20:27 +0100, Peter HÃwe wrote:
> > the reason behind this change was that spaces and tabs were mixed for 
> > indention. 
> 
> Checkpatch isn't gospel and isn't always right.
> 
> There should be room for taste preference here
> and I think whatever Petr V's is should prevail.
> 
> > How about this indention? Would this be better?
> 
> Well, I don't think so, but others will have different opinions.

I don't see it as an improvement either. Was checkpatch.pl really
complaining about the alignment? Tabs followed by less than 8 spaces is
acceptable and fairly common AFAICT, I can't remember the script
yelling at me when I do it.


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/