Re: [x86] Unify semaphore_32.S and rwlock_64.S

[H. Peter Anvin]

On 01/19/2010 02:21 PM, Christoph Lameter wrote:
> 
> From: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>
> Subject: [x86] Unify semaphore_32.S and rwlock_64.S
> 
> Both implement semaphore handling and the code for __read_lock_failed()
> and __write_lock_failed() look eearily similar aside from the use of
> different registers.
> 
> Create a new arch/x86/lib/semaphore.S out of the two files.
> 

Hi Christoph,

Could you do this in the standard sequencing for unification patches:
first patch the two pieces of code so they are identical, and then
mechanically unifying them?  Otherwise it's almost impossible to see
what has changed.

> This is also a good preparatory patch for getting the rwsem XADD stuff
> to work on x86_64.

Have you tried the tip:x86/rwsem branch (Linus' work with a few
additions of mine) and had it not work for you?

> x86_64 gains the FRAME/ENDFRAME handling that i386 has (not sure what the
> point is of having that there).

Presumably it's so you can have frame pointers everywhere.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/