Re: [PATCH] perf tools: fix write_event()
From: Peter Zijlstra
Date: Wed Jan 20 2010 - 09:15:26 EST
On Wed, 2010-01-20 at 12:09 -0200, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jan 20, 2010 at 02:44:56PM +0100, Peter Zijlstra escreveu:
> > On Wed, 2010-01-20 at 14:41 +0100, Peter Zijlstra wrote:
> > > On Wed, 2010-01-20 at 21:34 +0800, Xiao Guangrong wrote:
> > > > We parse the event while it's read from mmap buffer in
> > > > write_event(), but sometimes the event will straddles the
> > > > mmap boundary, we should handle this case
> > > >
> > > > And if we record events(such as perf kmem/sched) for long
> > > > times, Ctrl + C can't interrupt it just for this reason
> > >
> > > Uhm, how why? it didn't used to know about events and just copied the
> > > data.
> > looks like acme wrecked it in f5a2c3dc.. anyway the fix is wrong, record
> > should not know or care about the actual events and simply write data
> > out.
> Oh well, I guess then we should do that after record finishes,
> reprocessing all the data in the file.
Why do we need it at all?
Can't report/archive/etc.. sort all this out?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/