Re: [PATCH] Disable i8042 checks on Intel Apple Macs

From: Bastien Nocera
Date: Wed Jan 20 2010 - 14:38:23 EST


On Wed, 2010-01-20 at 11:14 -0800, Justin P. Mattock wrote:
> On 01/20/10 10:23, Bastien Nocera wrote:
> > As those computers never had any i8042 controllers, and the
> > current lookup code could potentially lock up/hang/wait for
> > timeout for long periods of time.
> >
> > Fixes intermittent hangs on boot on a MacbookAir1,1
<snip>
> glad you submitted this. i.g. been looking at some dmi
> blacklist thing over here(been racking my brain around
> a bit, and seeing your idea simplified it a bit more for me).

Yeah, dmi_check_system() returns the number of matches. I had to look up
the code to see what it did :)

> as for what you have here, do you think individually
> defining each machine is safer, or does it not matter?

For this particular case, it's not necessary, as none of the Apple
machines ever had any i8042 hardware. Or at least that's what Peter
Jones told me, and I have no reasons to doubt him.

Cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/