Re: [PATCH 1/2] lib: more scalable list_sort()
From: Andi Kleen
Date: Fri Jan 22 2010 - 05:43:31 EST
Don Mullis <don.mullis@xxxxxxxxx> writes:
> Being just a dumb library routine, list_sort() has no idea what context
> it's been called in, how long a list a particular client could pass in,
> nor how expensive the client's cmp() callback might be.
> The cmp() callback already passes back a client-private pointer.
> Hanging off of this could be a count of calls, or timing information,
> maintained by the client. Whenever some threshold is reached, the
> client's cmp() could do whatever good CPU-sharing citizenship required.
need_resched() does all the timing/thresholding (it checks the
reschedule flag set by the timer interrupt). You just have to call it.
But preferable not in the inner loop, but in a outer one. It's
not hyper-expensive, but it's not free either.
The drawback is that if it's called the context always has to
allow sleeping, so it might need to be optional.
Anyways a better fix might be simply to ensure in the caller
that lists never get as long that they become a scheduling
hazard. But you indicated that ubifs would pass very long lists?
Perhaps ubifs (and other calls who might have that problem) simply
needs to be fixed.
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/