Re: [PATCH] PM / i915: Skip kernel VT switch during suspend/resumeif KMS is used

From: Jesse Barnes
Date: Mon Jan 25 2010 - 13:35:43 EST

On Sun, 24 Jan 2010 00:55:59 +0100
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> From: Rafael J. Wysocki <rjw@xxxxxxx>
> If a non-KMS graphics driver is used, the kernel carries out a VT
> switch during suspend/resume to avoid possible problems with freezing
> X at a wrong time and to cause X to repaint everything after resume.
> This is not necessary any more if the KMS is used, so skip the kernel
> VT switch during suspend/resume for i915 in the KMS mode.
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> ---
> Hi,
> I've been testing this patch for over a week and haven't seen a
> single problem related to it during this time.
> Are there any objections to it?

This probably belongs in the core DRM KMS code instead of the driver.
I can imagine that there may be some X driver code that still needs to
be executed on suspend/resume for some drivers, so this may introduce
bugs, but it's definitely the right way to go.


Jesse Barnes, Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at