Re: [Bug #15124] PCI host bridge windows ignored (works withpci=use_crs)

From: Linus Torvalds
Date: Wed Jan 27 2010 - 15:51:51 EST




On Wed, 27 Jan 2010, Bjorn Helgaas wrote:
>
> Without intel_bus.c, we essentially assume config 1 all the time.
> If we keep intel_bus.c and this patch for .33, things should work
> for configs 1 and 4. Adding support for config 4 is good.

Quite frankly, is there any major downside to just disabling/removing
intel_bus.c for 2.6.33? If we're not planning on having it in the long run
anyway - or even if we are, but we can't be really happy about the state
of it as it would be in 2.6.33, not using it at all seems to be the
smaller headache.

The machines that it helps are also the machines where you can fix things
up with 'use_csr', no? And they are pretty rare, and they didn't use to
work without that use_csr in 2.6.32 either, so it's not even a regression.

Am I missing something?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/