Re: [RFC PATCH 5/5] gic: initialize interrupts as per argument

From: Russell King - ARM Linux
Date: Wed Jan 27 2010 - 18:32:07 EST

On Wed, Jan 27, 2010 at 11:32:29AM -0800, adharmap@xxxxxxxxxxxxxx wrote:
> From: Abhijeet Dharmapurikar <adharmap@xxxxxxxxxxx>
> Initialize interrupts as per an argument passed instead of initializing
> them as active level low triggered interrupts.
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@xxxxxxxxxxx>
> ---
> Configuring level triggered interrupts as default may not be correct on
> some platforms, this changes the default behaviour of the gic_dist_init
> function and also adds a flag to indicate whether the default should be level
> or edge.

Changing the interrupt type for all interrupts is just wrong. For on-chip
peripherals, you generally want to use level based interrupts as they're
the most efficient and simplest way to signal interrupts.

It should be a per-interrupt thing, and we already have that through
request_irq() etc. Other platforms manage this just fine without having
to have special configuration like this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at