Re: [PATCH v4 1/2] sysctl clean up vm related variable declarations

From: KAMEZAWA Hiroyuki
Date: Thu Jan 28 2010 - 05:34:30 EST


On Thu, 28 Jan 2010 00:54:49 -0800 (PST)
David Rientjes <rientjes@xxxxxxxxxx> wrote:

> > ---
> > include/linux/mm.h | 5 +++++
> > include/linux/mmzone.h | 1 +
> > include/linux/oom.h | 5 +++++
> > kernel/sysctl.c | 16 ++--------------
> > mm/mmap.c | 5 +++++
> > 5 files changed, 18 insertions(+), 14 deletions(-)
> >
> > Index: mmotm-2.6.33-Jan15-2/include/linux/mm.h
> > ===================================================================
> > --- mmotm-2.6.33-Jan15-2.orig/include/linux/mm.h
> > +++ mmotm-2.6.33-Jan15-2/include/linux/mm.h
> > @@ -1432,6 +1432,7 @@ int in_gate_area_no_task(unsigned long a
> > #define in_gate_area(task, addr) ({(void)task; in_gate_area_no_task(addr);})
> > #endif /* __HAVE_ARCH_GATE_AREA */
> >
> > +extern int sysctl_drop_caches;
> > int drop_caches_sysctl_handler(struct ctl_table *, int,
> > void __user *, size_t *, loff_t *);
> > unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
> > @@ -1476,5 +1477,9 @@ extern int soft_offline_page(struct page
> >
> > extern void dump_page(struct page *page);
> >
> > +#ifndef CONFIG_NOMMU
> > +extern int sysctl_nr_trim_pages;
>
> This should be #ifndef CONFIG_MMU.
>
yes...thank you for review.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/