Re: [Bug #15124] PCI host bridge windows ignored (works withpci=use_crs)

From: Jesse Barnes
Date: Thu Jan 28 2010 - 11:25:02 EST


On Wed, 27 Jan 2010 22:02:26 -0600
jeff@xxxxxxxxxxxx (Jeff Garrett) wrote:

> On Wed, Jan 27, 2010 at 07:24:09PM -0800, Jesse Barnes wrote:
> > On Wed, 27 Jan 2010 17:50:17 -0800 (PST)
> > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > On Tue, 26 Jan 2010, Yinghai Lu wrote:
> > > >
> > > > [PATCH] x86/pci: don't use ioh resource if only have one ioh
> > >
> > > Please, no.
> > >
> > > This patch is too ugly to live.
> > >
> > > And it's totally unacceptable to probe every single possible PCI device
> > > for something like this.
> > >
> > > If we don't know enough about the hardware workings of those Intel bridges
> > > to know when they are active and how they decode things, then please let's
> > > just disable intel_bus.c entirely.
> > >
> > > There's no excuse for hacky tests like this.
> >
> > Ok, we'll just kill it entirely then. I'll send a patch tomorrow
> > unless Yinghai beats me to it.
>
> What about something like this (works for me, without pci=use_crs)?
>
> ---
> Remove intel_bus.c Intel-specific PCI/IOH logic
>
> Signed-off-by: Jeff Garrett <jeff@xxxxxxxxxxxx>

Yeah, looks good. I'll push to Linus today.

Thanks,
Jesse

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/