Re: [PATCH v8] RO/NX protection for loadable kernel modules

[Siarhei Liakh]

> Needs more brackets around arguments, otherwise someone calling it with
> a complex expression will get very upset.
[...]

Done.

> The core_text_size test should be enough here.

Done.

>> +                     begin_pfn = PFN_DOWN((unsigned long)mod->module_core);
>> +                     end_pfn = PFN_DOWN((unsigned long)mod->module_core +
>> +                                             mod->core_text_size);
>> +                     if (end_pfn > begin_pfn)
>> +                             set_memory_rw(begin_pfn << PAGE_SHIFT,
>> +                                                     end_pfn - begin_pfn);
>
> Much of this code might be neater if you created a helper:

Done.

> But these are minor: patch looks good!

Thanks for your feedback!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/