Re: Split 'flush_old_exec' into two functions - 221af7f87b97431e3ee21ce4b0e77d5411cf1549

From: Michal Simek
Date: Tue Feb 02 2010 - 05:16:57 EST


H. Peter Anvin wrote:
On 02/01/2010 07:57 AM, Linus Torvalds wrote:
That said, Microblaze is not one of the architectures I would have expected to have problems. It has one of the most straightforward "flush_thread()" implementations in the whole kernel (it's a no-op ;), and that's where most of the hacky things were for the architectures that needed the change. And it has no "arch_pick_mmap_layout()" issues or anything else that tends to depend on personality bits or whatever.

Microblaze is a no-MMU platform, isn't it? Which binary format does it use? It looks like _some_ binaries work (it seems to happily be running a shell to actually do those startup scripts) while others have problems. Is there a difference between "/bin/sh" and the binaries that seem to be problematic (like /bin/mount and /bin/ifup).

Are the failing binaries all setuid ones, for example? Or shared vs non-shared? Or ELF vs FLAT or whatever?


Another thing... it looks like you [Michal] is running a test image
under Qemu... could you perhaps point us to that image or another test
image which reproduces the problem?

Yes, you are right. I am doing every day testing on qemu.
I have prepared package which contain all things which you need.
Please download it from http://www.monstr.eu/20100202-flush.tar.gz
md5sum cfe59b19e52dff2319a2b1919839d5cd 20100202-flush.tar.gz

I added there README where you will find more information. Also there is rootfs.cpio which you can use. Compile kernel with this patch and try. Then you can revert it and retest - you should be able to see that behavior.

If you have any problem with it, please let me know.

Michal

P.S.: you don't need to care about FPU error in bootlog - fpu is not used.


Nothing like having a hands-on testcase...

-hpa



--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/