Re: [PATCH] netfilter: per netns nf_conntrack_cachep

[Jon Masters]

On Mon, 2010-02-01 at 16:02 +0100, Eric Dumazet wrote:
> Le lundi 01 fÃvrier 2010 Ã 16:58 +0200, Alexey Dobriyan a Ãcrit :
> > On Mon, Feb 1, 2010 at 4:52 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> > > +       net->ct.nf_conntrack_cachep = kmem_cache_create("nf_conntrack",
> > > +                                                       sizeof(struct nf_conn), 0,
> > > +                                                       SLAB_DESTROY_BY_RCU, NULL);
> > 
> > Duplicate slab name detected.
> > 
> 
> OK, need to build an unique name I guess... "nf_conntrack-%d", net->id

I shoved in an kasprintf but of course there isn't a per-namespace "id".
We probably should have one (or, a nice "name"), but meanwhile I am
using the address of the net struct like "nf_ct-%p".

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/