Re: [RFC][PATCH] PM: disable nonboot cpus before suspending devices

From: Andrew Morton
Date: Tue Feb 02 2010 - 20:49:50 EST


On Wed, 3 Feb 2010 02:44:23 +0100 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> +static inline gfp_t clear_gfp_allowed_mask(gfp_t mask)
> +{
> + gfp_t ret = gfp_allowed_mask;
> + gfp_allowed_mask &= ~mask;
> + return ret;
> +}

Fair enuf.

Of course, this is all horridly racy/buggy without locking. Would I be
correct in hoping that all the callers happen when the system is in
everyone-is-frozen mode?

Perhaps we should add some documentation (or even an assertion) to
prevent someone from using these interfaces from within normal code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/