Re: [PATCH 2/3] trace-cmd: fix printf compile warnings

From: John Kacur
Date: Wed Feb 03 2010 - 11:40:32 EST


On Wed, Feb 3, 2010 at 5:31 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 2010-02-03 at 17:07 +0100, John Kacur wrote:
>> On Mon, Feb 1, 2010 at 5:50 PM, Darren Hart <dvhltc@xxxxxxxxxx> wrote:
>> > Signed-off-by: Darren Hart <dvhltc@xxxxxxxxxx>
>> > ---
>> >  trace-read.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/trace-read.c b/trace-read.c
>> > index a04c85b..5befaba 100644
>> > --- a/trace-read.c
>> > +++ b/trace-read.c
>> > @@ -216,7 +216,7 @@ static void read_rest(void)
>> >                r = read(input_fd, buf, BUFSIZ);
>> >                if (r > 0) {
>> >                        buf[r] = 0;
>> > -                       printf(buf);
>> > +                       printf("%s", buf);
>> >                }
>> >        } while (r > 0);
>> >  }
>> > --
>> > 1.6.3.3
>> >
>>
>> Oh! Obviously correct, thanks Darren.
>
> Of the three patches, I think this is the only one that is correct ;-)
>

Ah, you're a hard taskmaster! Are you going to push it to your repo
for us then pls?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/