Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

From: Pekka Sarnila
Date: Thu Feb 04 2010 - 09:05:56 EST


Yes, my comment maybe criticizes more the basic architectural structure of usb putting it's own work up to higher layer. The only practical thing is that, if there is a non-HID device suffering from that FULLSPEED problem, the quirk won't help it. Anyway in current kernel structure usb layer doesn't handle endpoint setup at all, thus it simply can not do the job.

Pekka

Jiri Kosina wrote:

Yes, I still think what I have stated before, that this should be properly handled in the USB stack.

On the other hand, in usbhid driver we do a lot of USB-specific lower-level things anyway, so it's technically more-or-less OK to apply the quirk there as well (and that's why I have accepted it back then).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/