Re: [PATCH 1/9] platform-drivers: move probe to .devinit.text inarch/arm

From: Kristoffer Ericson
Date: Thu Feb 04 2010 - 16:08:51 EST


On Thu, 4 Feb 2010 23:56:06 +0300
Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> wrote:

> On Thu, Feb 04, 2010 at 08:56:49PM +0100, Uwe Kleine-KÃnig wrote:
> > A pointer to a probe callback is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> >
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
> >
> > Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Arnaud Patard <arnaud.patard@xxxxxxxxxxx>
> > Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> > Cc: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> > Cc: Eric Miao <eric.miao@xxxxxxxxxxx>
> > Cc: Kristoffer Ericson <Kristoffer.Ericson@xxxxxxxxx>
> > Cc: Liam Girdwood <liam.girdwood@xxxxxxxxxxxxxxxx>
> > Cc: Paul Sokolovsky <pmiscml@xxxxxxxxx>
> > Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> > Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
>
> sharpsl_pm part:
> Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>

jornada part:
Acked-by: Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>

>
> --
> With best wishes
> Dmitry
>


--
Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/