Re: [Patch 0/2] sysfs: fix s_active lockdep warning

From: Alan Stern
Date: Thu Feb 04 2010 - 23:07:00 EST


On Fri, 5 Feb 2010, Cong Wang wrote:

> Alan Stern wrote:
> > On Thu, 4 Feb 2010, Peter Zijlstra wrote:
> >
> >> On Thu, 2010-02-04 at 11:35 -0500, Alan Stern wrote:
> >>> +#include <linux/sched.h>
> >> #include <linux/lockdep.h>
> >>
> >> should be sufficient I think.
> >
> > No, it's not. It leaves MAX_LOCK_DEPTH undeclared. Beats me why that
> > symbol ended up in sched.h...
> >
>
> because task_struct->held_locks uses it, but it seems better to move
> it into lockdep.h...

Be my guest! :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/