Re: [PATCH] cciss: Make cciss_seq_show handle holes in theh->drv[] array.

From: Jens Axboe
Date: Fri Feb 05 2010 - 07:14:49 EST


On Thu, Feb 04 2010, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>
> cciss: Make cciss_seq_show handle holes in the h->drv[] array.
> It is possible (and expected) for there to be holes in the h->drv[]
> array, that is, some elements may be NULL pointers. cciss_seq_show
> needs to be made aware of this possibility to avoid an Oops.
>
> To reproduce the Oops which this fixes:
>
> 1) Create two "arrays" in the Array Configuratino Utility and
> several logical drives on each array.
> 2) cat /proc/driver/cciss/cciss* in an infinite loop
> 3) delete some of the logical drives in the first "array."
>
> Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>

Thanks Stephen, applied for 2.6.33. BTW, you want to put that stable cc
into the patch itself as well, then it'll get picked up automatically
when Linus merges it.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/