Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs

[Evgeniy Polyakov]

On Wed, Feb 10, 2010 at 10:04:28AM +0000, Al Viro (viro@xxxxxxxxxxxxxxxxxx) wrote:
> a) pohmelfs_construct_path_string() will do interesting things if you
> call it while chrooted into jail and pohmelfs mounted deeper in that
> jail.  Try it.

Should it walk upto mountpoint?

> b) just why do we care about root of chroot jail in pohmelfs_path_length()?
> Not to mention anything else, current->fs->root/mnt may be changed under
> you if you share current->fs with another thread, but even aside of that,
> why does filesystem care about chroot of caller at all?
> 
> What's going on there?

It tries to construct a full path upto mountpoint. Effectively it should
do similar to non-exported dentry_path() things. There is a race between
getting buffer size and filling with the actual path, but we take care
about that by restarting if needed.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/