Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs

From: Evgeniy Polyakov
Date: Wed Feb 10 2010 - 08:30:18 EST


On Wed, Feb 10, 2010 at 11:59:39AM +0000, Al Viro (viro@xxxxxxxxxxxxxxxxxx) wrote:
> > Let me guess... Mmmm, it was in the yesterday newspaper, I remember.
> > Maybe when we chroot somewhere. I meant not mounted fs root, but
> > thread's root.
>
> Why would a filesystem give a damn about the chroot of syscall originator
> in the first place?

That's the point - it is not needed.

> > > Why not use the dentries you've been given by VFS?
> >
> > At writeback we do not have parents, so must find a path somehow.
>
> Most of the places do have those just fine and unlike the writeback,
> rename et.al. really care which pathname is being dealt with...

POHMELFS uses writeback cache also for metadata, so effectively most of
such operations are also postponed. Later I turned that off though.

> BTW, what prevents writeback vs. rename races?

There are proper locks for such operations.

--
Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/