m68knommu: duplicate _ramvec[vba+CPMVEC_RISCTIMER] assignment ininit_IRQ()

From: Roel Kluin
Date: Wed Feb 10 2010 - 09:03:33 EST


Hi,

Looking at arch/m68knommu/platform/68360/ints.c I noted two things that
stood out:

1) on line 110:

_ramvec[vba+CPMVEC_RISCTIMER] = inthandler; /* reserved */

and 114:

_ramvec[vba+CPMVEC_RISCTIMER] = inthandler; /* timer table */

The same definitions are used, and in the first case the comment and
definition do not correspond.

2) while all other definitions are used like this:

_ramvec[vba+CPMVEC_DEF2] = inthandler;
...
_ramvec[vba+CPMVEC_DEF1] = inthandler;

This is not true for CPMVEC_RESERVED:

_ramvec[vba+CPMVEC_RESERVED1] = inthandler; /* reserved */
...
_ramvec[vba+CPMVEC_RESERVED2] = inthandler; /* reserved */

Is this a bug?

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/