Re: [PATCH 1/1] DVB: ngene, fix memset parameters

From: Oliver Endriss
Date: Wed Feb 10 2010 - 23:32:46 EST


Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Matthias Benesch <twoof7@xxxxxxxxxx>
> Cc: Ralph Metzler <rjkm@xxxxxxxxxxxxxx>
> Cc: Oliver Endriss <o.endriss@xxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
> drivers/media/dvb/ngene/ngene-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
> {
> u32 *ptr = Buffer;
>
> - memset(Buffer, Length, 0xff);
> + memset(Buffer, 0xff, Length);
> while (Length > 0) {
> if (Flags & DF_SWAP32)
> *ptr = 0x471FFF10;
> --
> 1.6.6.1

Acked-by: Oliver Endriss <o.endriss@xxxxxx>

CU
Oliver

--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/