Re: linux-next: build warning after merge of the suspend tree

From: Alan Stern
Date: Thu Feb 11 2010 - 10:32:17 EST


On Thu, 11 Feb 2010, Rafael J. Wysocki wrote:

> On Thursday 11 February 2010, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the suspend tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/usb/core/hcd-pci.c:138: warning: 'wait_for_companions' defined but not used
> >
> > Introduced by commit ce74abf51a15ab82a9fae6dcd8a9c0038945f10e ("USB:
> > implement non-tree resume ordering constraints for PCI host controllers").
>
> Thanks for the info, I'll fix this up later today in my tree.

Clearly wait_for_companions() needs to be inside "#ifdef
CONFIG_PM_SLEEP ... #endif". In fact, all the new functions added by
the patch should be protected this way, with suitable do-nothing inline
versions provided when CONFIG_PM_SLEEP isn't defined.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/