Re: [PATCH] Add Dell Business Class Netbook LED driver

[Dmitry Torokhov]

On Thu, Feb 11, 2010 at 06:07:15PM +0000, Matthew Garrett wrote:
> On Thu, Feb 11, 2010 at 10:05:19AM -0800, Dmitry Torokhov wrote:
> 
> > Or stuck it in dell-wmi.c...
> 
> I'd prefer not to put it in dell-wmi. There's no logical association 
> between it and the rest of the code there, so it'd just be overhead on 
> the majority of systems. With the exception of cases where the event and 
> functional interfaces are different GUIDs, I'd prefer a one GUID per 
> driver model.
> 

This is an opposite direction form the rest of the platform drivers
which tend to combine functionality on per-vendor basis in one driver.

I'd say that in this case with this LED driver overhead on DELL systems
not supportinfg it is miniscule. The benefit is that all vendor-specific
sub-devices are children of one parent platform device.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/