Re: [PATCH] Add Dell Business Class Netbook LED driver

[Matthew Garrett]

On Thu, Feb 11, 2010 at 10:28:30AM -0800, Dmitry Torokhov wrote:

> This is an opposite direction form the rest of the platform drivers
> which tend to combine functionality on per-vendor basis in one driver.

I don't think that's true - we /tend/ to see one driver per ACPI device 
or device interface (see the dell-wmi/dell-laptop split, for instance).

> I'd say that in this case with this LED driver overhead on DELL systems
> not supportinfg it is miniscule. The benefit is that all vendor-specific
> sub-devices are children of one parent platform device.

I really don't see that as a strong benefit.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/