Re: [PATCH 02/11] tracing: Introduce TRACE_EVENT_INJECT

[Steven Rostedt]

On Thu, 2010-02-11 at 19:57 +0100, Frederic Weisbecker wrote:
> On Wed, Feb 10, 2010 at 09:05:06AM -0500, Steven Rostedt wrote:

> > Looking back at where trace_lock_class_init() was placed, you don't need
> > a wrapper. But instead, why not just have perf hook directly into the
> > trace_lock_class_init trace point, and do its injection directly.
> > Instead of needing to add some hack to TRACE_EVENT()?
> 
> 
> We could. But we expect further events may need such catch-up by
> injection system. And ftrace will also need to perform this injection.
> 
> That's why I think something more generic would be more reasonable.
> 

Hmm, I'm a bit dense lately and still a bit confused.

Why is an injector needed exactly, and why would ftrace want one too?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/