Re: [PATCH 1/2] Staging: hv: Add proper versioning to HV drivers

[Greg KH]

On Thu, Feb 11, 2010 at 09:32:29PM +0000, Hank Janssen wrote:
> 
> Provide proper versioning information for all HV drivers.
> 
> 
> Cc: Greg Kroah-Hartman         <gregkh@xxxxxxx>
> Signed-off-by: Hank Janssen    <hjanssen@xxxxxxxxxxxxx>
> Signed-off-by: Haiyang Zhang   <haiyang@xxxxxxxxxxxxx>
> 
> 
>  drivers/staging/hv/VersionInfo.h |   11 ++++++++---
>  drivers/staging/hv/Vmbus.c       |    8 ++++----
>  drivers/staging/hv/blkvsc_drv.c  |    2 ++
>  drivers/staging/hv/netvsc_drv.c  |    5 +++--
>  drivers/staging/hv/storvsc_drv.c |    2 ++
>  drivers/staging/hv/vmbus_drv.c   |    2 ++
>  6 files changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/hv/VersionInfo.h b/drivers/staging/hv/VersionInfo.h
> index 9c3641d..e729b9e 100644
> --- a/drivers/staging/hv/VersionInfo.h
> +++ b/drivers/staging/hv/VersionInfo.h
> @@ -24,8 +24,13 @@
>  #ifndef __HV_VERSION_INFO
>  #define __HV_VERSION_INFO
>  
> -static const char VersionDate[] = __DATE__;
> -static const char VersionTime[] = __TIME__;
> -static const char VersionDesc[] = "Version 2.0";
> +static const char hv_build_date[] = __DATE__;
> +static const char hv_build_time[] = __TIME__;

This should not be needed at all, as it make absolutely no sense.

> +/*
> + * We use the same version numbering for all Hyper-V modules.
> + */
> +#define HV_DRV_VERSION           "3.0.0"

Is this really needed?  Now that the code is in the kernel tree,
shouldn't you be tracking this based on kernel release version (like 90%
of the drivers are tracked), or is there some requirement for a version
number?

And what decides when this number is changed?  What does it "mean"?
What is it tracking?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/