Re: [PATCH 0/8] tip related: radix tree for spareseirq and logicalflat clean up

[H. Peter Anvin]

On 02/12/2010 07:44 PM, Eric W. Biederman wrote:
> 
> Thanks for keeping this work alive.
> 

Indeed.  I am hoping to put this in tip tomorrow or so.

> I just skimmed through do_IRQ and I happened to notice that
> we have an unnecessary inefficiency that using a radix tree for
> irq_to_desc will magnify.
> 
> handle_irq should take an struct irq_desc * instead of a unsigned int irq.
> 
> and the per cpu vector_irq array should become a per cpu vector_desc array.
> 
> As soon as irq_to_desc is more than &irq_desc[irq] this saves us work
> and cache line misses  at the cost of a simple code cleanup.

Good catch.  I haven't looked through the details yet, but I presume
this can be done on top of this changeset?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/