Re: [net-next PATCH v3 3/3] net: TCP thin dupack

From: Andreas Petlund
Date: Sat Feb 13 2010 - 10:58:26 EST


On 13. feb. 2010 03:13, Eric W. Biederman wrote:
> Andreas Petlund <apetlund@xxxxxxxxx> writes:
>
>> Major changes:
>> -Possible to disable mechanisms by socket option
>> -Socket option value boundary check
>>
>>
>> Signed-off-by: Andreas Petlund <apetlund@xxxxxxxxx>
>> ---
>> include/linux/sysctl.h | 1 +
>> include/linux/tcp.h | 4 +++-
>> include/net/tcp.h | 1 +
>> net/ipv4/sysctl_net_ipv4.c | 7 +++++++
>> net/ipv4/tcp.c | 7 +++++++
>> net/ipv4/tcp_input.c | 11 +++++++++++
>> 6 files changed, 30 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
>> index d840d75..ded3f20 100644
>> --- a/include/linux/sysctl.h
>> +++ b/include/linux/sysctl.h
>> @@ -426,6 +426,7 @@ enum
>> NET_TCP_MAX_SSTHRESH=124,
>> NET_TCP_FRTO_RESPONSE=125,
>> NET_TCP_FORCE_THIN_LINEAR_TIMEOUTS=126,
>> + NET_TCP_FORCE_THIN_LINEAR_DUPACK=127,
>
> There is no need to allocate a binary sysctl here.
>
> Eric

Thanks. I'll address this in the next iteration.

Best regrads,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/