Re: [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length assumptions

[William Allen Simpson]

Andi Kleen wrote:
> On Mon, Feb 15, 2010 at 07:28:44AM -0500, William Allen Simpson wrote:
> > Harmonize tcp_v4_rcv() and tcp_v6_rcv() -- better document tcp doff
> > and header length assumptions, and carefully compare implementations.
>
> I didn't fully understand that new comment:
>
> /* nf_reset(skb); in ip6_input.c ip6_input_finish() */
That's part of the harmonization.  IPv4 has a nf_reset() in this code
position.  I asked on the list where IPv6 did the same thing, so that
the difference could be documented.  The information was provided by
Patrick McHardy.  If someday somebody actually finishes merging the
two functions, that's the only actual difference.


> Overall you can add a 
>
> Reviewed-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
Thanks, hopefully as applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/