Re: [PATCH] fs: Add flags to __d_path for suppressing suffix andmapping /proc/self

From: Christoph Hellwig
Date: Mon Feb 15 2010 - 11:15:32 EST


On Mon, Feb 15, 2010 at 11:11:37PM +0900, Tetsuo Handa wrote:
> This patch allows __d_path() to
> (1) suppress " (deleted)" suffix if dentry was already deleted

This part looks fine to me.

> (2) convert /proc/PID to /proc/self if dentry is under /proc/self directory

This not. If you security module is broken enough to require special
casing /proc/pid entries that's your business, but there's not reason
to put ugly hacks into core code for that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/