Re: [PATCH 1/4] nmi_watchdog: use a boolean config flag for compiling

[Don Zickus]

On Mon, Feb 15, 2010 at 09:21:17PM +0300, Cyrill Gorcunov wrote:
> On Mon, Feb 15, 2010 at 09:13:01PM +0300, Cyrill Gorcunov wrote:
> ...
> > > Looking through the code, is there ever case where 'apic' is undefined?
> > > The arch_trigger_all_cpu_backtrace should match identically to the old nmi
> > > code, so I am stuck on how to fix this.
> > > 
> > > Thoughts?
> > > 
> > 
> > It looks familiar to one problem with HW breakpoints "Kconfig select"
> > issue Frederic fixed once not that long ago, if I recall correctly.
> > 
> > So due to select we choose to compile hw_nmi.c, but CONFIG_LOCAL_APIC
> > (or APIC on UP) is turned off. So apic.c is not compiled. And at stage
> > of linking we get unresolved symbol.


Hmm thanks for the feedback.  The code can handle CONFIG_LOCAL_APIC being
turned off.  I'll look more at the UP stuff.

> > 
> > I don't remember the details how Frederic fixed HW breakpoints "select"
> > issue, CC'ed :) But you may google to find it out.
> >
> 
> Here is what I mean http://patchwork.kernel.org/patch/67973/

I don't believe I have the same issue.  Thanks for the pointer.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/