Re: [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT

From: Oleg Nesterov
Date: Tue Feb 16 2010 - 12:45:38 EST


On 02/16, Linus Torvalds wrote:
>
> And after we have switched to 32-bit mode, we _are_ inside a 32-bit system
> call: the execve has "changed" from a 64-bit one to a 32-bit one.
>
> So I really don't understand why you dislike TS_COMPAT here.

and, following this logic, shouldn't set_personality_64bit() clear
TS_COMPAT ?

OK, in any case I do not claim we need fixes. Just I am confused.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/