Re: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to takeirq_desc in addition to irq

[H. Peter Anvin]

On 02/18/2010 09:04 AM, Eric W. Biederman wrote:
> 
> May I ask why these methods and why pass both irq and desc instead of
> just desc?
> 
> I think in the long run passing both irq and desc through several
> functions may incur some maintenance cost that it would be nice not to
> pay (register pressure and increased chance of typos).
> 

Indeed; if the IRQ number is needed the function should just get it from
desc->irq.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/