Re: [PATCH -next] i2c: fix xiic build error

From: Geert Uytterhoeven
Date: Mon Feb 22 2010 - 14:03:15 EST


On Mon, Feb 22, 2010 at 17:36, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> On 02/16/10 08:36, Randy Dunlap wrote:
>> On 02/16/10 08:33, Jean Delvare wrote:
>>> On Tue, 16 Feb 2010 08:07:05 -0800, Randy Dunlap wrote:
>>>> On 02/04/10 12:11, Randy Dunlap wrote:
>>>>
>>>> This patch is still needed in linux-next-20100216.
>>>
>>> Nothing I can do about it, as the i2c-xiic driver is neither upstream
>>> nor in my tree.
>>
>> Thanks, Jean.
>>
>> Next/merge.log tells me:
>> Merge remote branch 'bjdooks-i2c/next-i2c'
>>
>> Ben??
>>
>
> ping Ben.

Yes, please. Thx!

> Here's the patch again.
>
> ---
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Add header file to fix build error:
>
> drivers/i2c/busses/i2c-xiic.c:493: error: implicit declaration of function 'mdelay'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: "Ben Dooks (embedded platforms)" <ben-linux@xxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx
> ---
> Âdrivers/i2c/busses/i2c-xiic.c | Â Â1 +
> Â1 file changed, 1 insertion(+)
>
> --- linux-next-20100204.orig/drivers/i2c/busses/i2c-xiic.c
> +++ linux-next-20100204/drivers/i2c/busses/i2c-xiic.c
> @@ -31,6 +31,7 @@
> Â#include <linux/module.h>
> Â#include <linux/init.h>
> Â#include <linux/errno.h>
> +#include <linux/delay.h>
> Â#include <linux/platform_device.h>
> Â#include <linux/i2c.h>
> Â#include <linux/interrupt.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



--
Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/