Re: [RFC PATCH -tip 2/2 v2] add a scripts for pagecache usage perprocess

From: Peter Zijlstra
Date: Tue Feb 23 2010 - 13:13:55 EST


On Tue, 2010-02-23 at 18:54 +0100, Frederic Weisbecker wrote:

> > [PATCH] perf record: filter out perf process tracepoint events
> >
> > The perf process itself can generate a lot of trace data, which most
> > of the time isn't of any interest. This patch adds a predicate to the
> > kernel tracepoint filter of each recorded event type which effectively
> > screens out any event generated by perf.
> >
> > Assuming the common case would be to ignore perf, this makes it the
> > default; the old behavior can be selected by using 'perf record -P'.
>
>
> I think filtering out perf from the instrumentation is a very
> desirable features.
>
> But I see two drawbacks with this patch.
> First of all, we want to keep perf as a part of the instrumentation
> as a default behaviour I think, as it is a true part of the system
> wide load. So I would rather suggest to keep it as a default and
> have an exclude_perf option instead of include_perf.

Agreed, excluding by default doesn't seem to be a sane idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/