Re: QUERY: Inclusion of header files in kernel header files

[Theodore Tso]

On Feb 23, 2010, at 11:28 PM, viresh kumar wrote:

>> Before someone goes crazy and starts sending hundreds of patches to the trivial patch folks,
>> please make sure that you only do this for places where header file foo uses "struct bar" in
>> bar.h --- and NOT if it is using "struct bar *".    Blind structure pointers don't cause compile
>> failures, and is a perfectly good thing from the standpoint of data hiding.
>> 
> 
> Ted,
> Actually bus.h is using direct instances of these structures and thus
> it is giving compilation warnings.

I'm aware of that --- in this case.   However, this would not be the first time some over-eager kernel programmer newbie finds a message in LKML, reads it out of context, and then starts sending large number of useless, and even potentially harmful patches which all of the kernel maintainers then have to check and NACK.

So while I was pretty sure you knew what you meant, the fact that other people were saying, "Yeah!  Let's sweep through the header files finding all of these potential problems and clean them up," sent a chill down my spine.

													-- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/