[tip:core/rcu] rcu: Make lockdep_rcu_dereference() message less alarmist

From: tip-bot for Paul E. McKenney
Date: Fri Feb 26 2010 - 04:30:08 EST


Commit-ID: 056ba4a9bea5f32781a36b797c562fb731e5eaa6
Gitweb: http://git.kernel.org/tip/056ba4a9bea5f32781a36b797c562fb731e5eaa6
Author: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
AuthorDate: Thu, 25 Feb 2010 14:06:46 -0800
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Fri, 26 Feb 2010 08:20:46 +0100

rcu: Make lockdep_rcu_dereference() message less alarmist

Change from "unsafe" to "suspicious", given that there will be
false alarms.

Suggested-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
Cc: laijs@xxxxxxxxxxxxxx
Cc: dipankar@xxxxxxxxxx
Cc: mathieu.desnoyers@xxxxxxxxxx
Cc: josh@xxxxxxxxxxxxxxxx
Cc: dvhltc@xxxxxxxxxx
Cc: niv@xxxxxxxxxx
Cc: peterz@xxxxxxxxxxxxx
Cc: rostedt@xxxxxxxxxxx
Cc: Valdis.Kletnieks@xxxxxx
Cc: dhowells@xxxxxxxxxx
LKML-Reference: <1267135607-7056-1-git-send-email-paulmck@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
kernel/lockdep.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 672c436..0c30d04 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3816,9 +3816,9 @@ void lockdep_rcu_dereference(const char *file, const int line)

if (!debug_locks_off())
return;
- printk("\n==============================================\n");
- printk( "[ BUG: Unsafe rcu_dereference_check() usage! ]\n");
- printk( "----------------------------------------------\n");
+ printk("\n===================================================\n");
+ printk( "[ INFO: suspicious rcu_dereference_check() usage. ]\n");
+ printk( "---------------------------------------------------\n");
printk("%s:%d invoked rcu_dereference_check() without protection!\n",
file, line);
printk("\nother info that might help us debug this:\n\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/